Skip to content

chore: Update VegaFusion version#81

Open
OlegWock wants to merge 3 commits intomainfrom
oleh/blu-5824-update-vegafusion-in-the-toolkit
Open

chore: Update VegaFusion version#81
OlegWock wants to merge 3 commits intomainfrom
oleh/blu-5824-update-vegafusion-in-the-toolkit

Conversation

@OlegWock
Copy link
Contributor

@OlegWock OlegWock commented Mar 19, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Improved PySpark DataFrame handling in chart rendering so charts now correctly accept Spark-backed data sources.
  • Chores

    • Relaxed vegafusion dependency constraint to allow a newer minor release, ensuring compatibility with recent vegafusion improvements.

@linear
Copy link

linear bot commented Mar 19, 2026

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4a6fa398-4adf-4ab1-9a5d-6811c5256ae2

📥 Commits

Reviewing files that changed from the base of the PR and between 22022d5 and 2bcece5.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • deepnote_toolkit/chart/deepnote_chart.py

📝 Walkthrough

Walkthrough

Two changes modify how PySpark DataFrames are processed in VegaFusion chart creation and update the related dependency. The chart module now returns a VegaFusion ExternalDataset descriptor instead of a raw Arrow schema for PySpark inputs, using protocol='spark' and an Arrow schema derived from spark_df.schema. The deepnote-vegafusion dependency minimum version bumps from 2.0.8 to 2.1.0, maintaining the same upper bound. Control flow and error handling remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately reflects the main changes: VegaFusion version bump in pyproject.toml and related code updates to support the new version.
Updates Docs ✅ Passed PR updates VegaFusion dependency and refactors internal code; no new user-facing feature or documentation required.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.71%. Comparing base (28a265d) to head (2bcece5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files          93       93           
  Lines        5284     5284           
  Branches      766      766           
=======================================
  Hits         3895     3895           
  Misses       1144     1144           
  Partials      245      245           
Flag Coverage Δ
combined 73.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Mar 19, 2026

📦 Python package built successfully!

  • Version: 2.1.4.dev6+ee19f83
  • Wheel: deepnote_toolkit-2.1.4.dev6+ee19f83-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/2.1.4.dev6%2Bee19f83/deepnote_toolkit-2.1.4.dev6%2Bee19f83-py3-none-any.whl"

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pyproject.toml`:
- Line 130: The poetry lockfile is out of sync with the pyproject.toml change to
the "deepnote-vegafusion>=2.1.0,<3" dependency; regenerate the lockfile by
running `poetry lock` (or `poetry update deepnote-vegafusion`), verify tests/CI
locally, and commit the updated poetry.lock so CI sees the updated constraints.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7882857a-fd70-4943-b750-fced69d3ab46

📥 Commits

Reviewing files that changed from the base of the PR and between 28a265d and 22022d5.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • deepnote_toolkit/chart/deepnote_chart.py
  • pyproject.toml

@deepnote-bot
Copy link

deepnote-bot commented Mar 19, 2026

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-81
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2026-03-19 09:09:52 (UTC)
📜 Deployed commit 7a6dc8ef21d76a95e69f2588950ff69dea5d00b4
🛠️ Toolkit version ee19f83

@OlegWock OlegWock marked this pull request as ready for review March 19, 2026 10:48
@OlegWock OlegWock requested a review from a team as a code owner March 19, 2026 10:48
@OlegWock OlegWock requested a review from mfranczel March 19, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants