Pre-release cleanup: consolidate special-form metadata, drop design doc#23
Merged
Conversation
Collapse the three parallel lists describing higher-order forms (higherOrderForms dispatch, higherOrderNames suggester candidates, formCallHints signatures) into a single userForms slice in higher_order.go. Adding a form now means appending one entry; the derived tables stay in lockstep automatically. Also note in spec.md and llms.txt that ?? is intentionally not provided, since the question keeps coming up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final cleanup before cutting a release.
docs/design/language-evolution.md(the doc was untracked; deleted from disk in this branch and never committed to history).higherOrderForms(dispatch),higherOrderNames(suggester candidates),formCallHints(call-signature hints) — into a singleuserFormsslice inhigher_order.go. A previous reviewer flagged the drift risk: adding a form meant remembering to update three places. Now there's one.docs/reference/spec.mdandllms.txtrecording that??is intentionally not provided, since?./?[+ operand-returning||+try(...)cover the same use cases.No behavior changes. The "is a special form" hint, did-you-mean suggestions, and exact-match suppression all continue to work; verified with a probe.
Test plan
go build ./...go vet ./...go test -count=1 ./...— all greengo test -fuzz=FuzzCompile -fuzztime=5s .— no findingsgo test -fuzz=FuzzRewrite -fuzztime=5s ./internal/optaccess— no findingscount,try,mapproduce special-form hints;mapp→did you mean "map"?;flter→did you mean "filter"?