Skip to content

[codex] Fix struct tag ambiguity tests for vet #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myzie merged 1 commit into from
May 8, 2026
Merged

[codex] Fix struct tag ambiguity tests for vet #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions struct_tags_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,13 @@ func TestStructTags_NestedPointersAndEmbeddedStructs(t *testing.T) {

func TestStructTags_AmbiguousFieldAccessErrors(t *testing.T) {
type conflict struct {
Foo string `json:"value"`
Bar string `json:"value"`
Foo string `exprtest:"value"`
Bar string `exprtest:"value"`
}

_, err := evalExpr(t.Context(), `x.value`, map[string]any{
"x": conflict{Foo: "a", Bar: "b"},
}, WithStructTags("json"))
}, WithStructTags("exprtest"))
require.ErrorIs(t, err, ErrEvaluate)
require.Contains(t, err.Error(), `field "value" is ambiguous`)
}
Expand All @@ -144,11 +144,11 @@ func TestStructTags_CallableFieldAndSuggestions(t *testing.T) {

func TestStructTags_AmbiguityStillWrapsErrEvaluate(t *testing.T) {
type conflict struct {
Foo string `json:"value"`
Bar string `json:"value"`
Foo string `exprtest:"value"`
Bar string `exprtest:"value"`
}

p, err := Compile(`value`, WithStructTags("json"))
p, err := Compile(`value`, WithStructTags("exprtest"))
require.NoError(t, err)
_, err = p.Run(t.Context(), conflict{Foo: "a", Bar: "b"})
if !errors.Is(err, ErrEvaluate) {
Expand Down
Loading