Skip to content

fix: continue_on_success_ratio without slice raise error #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
saltball wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: continue_on_success_ratio without slice raise error #852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/dflow/step.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,8 @@ def merge_output_artifact(art, parent, layer=0):
self.template.set_slices(self.template.slices)
self.with_param = argo_range(if_expression(
"%s %% %s > 0" % (nslices, group_size),
"%s/%s + 1" % (nslices, group_size),
"(%s - %s %% %s) / %s + 1" % (nslices,
nslices, group_size, group_size),
"%s/%s" % (nslices, group_size)))
elif self.with_param is not None:
self.template.inputs.parameters["dflow_with_param"] = \
Expand All @@ -745,7 +746,8 @@ def merge_output_artifact(art, parent, layer=0):
self.template.set_slices(self.template.slices)
self.with_param = argo_range(if_expression(
"%s %% %s > 0" % (nslices, group_size),
"%s/%s + 1" % (nslices, group_size),
"(%s - %s %% %s) / %s + 1" % (nslices,
nslices, group_size, group_size),
"%s/%s" % (nslices, group_size)))
if self.with_sequence is not None:
self.template.inputs.parameters["dflow_sequence_start"] = \
Expand Down Expand Up @@ -799,7 +801,8 @@ def merge_output_artifact(art, parent, layer=0):
self.with_sequence = argo_sequence(
count=if_expression(
"%s %% %s > 0" % (nslices, group_size),
"%s/%s + 1" % (nslices, group_size),
"(%s - %s %% %s) / %s + 1" % (nslices,
nslices, group_size, group_size),
"%s/%s" % (nslices, group_size)), format=format)

self.inputs.parameters["dflow_nslices"] = InputParameter(
Expand Down Expand Up @@ -932,6 +935,7 @@ def add_success_tag(templ):
}
)
elif self.continue_on_success_ratio is not None:
total = 1
if "dflow_nslices" in self.inputs.parameters:
total = self.inputs.parameters["dflow_nslices"].value
elif self.with_param is not None:
Expand Down
Loading