Add gtest support for Sunway builds#7197
Open
A-006 wants to merge 7 commits intodeepmodeling:developfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds infrastructure to enable building/running GoogleTest-based unit tests on Sunway (USE_SW) builds, while selectively disabling known-problematic tests and aligning link dependencies for the platform.
Changes:
- Add a Sunway-focused script and tooling docs for building ABACUS with a local/offline GoogleTest.
- Adjust CMake test registration to skip specific unit test targets on USE_SW.
- Refactor USE_SW math/ScaLAPACK linkage setup to better unify dependencies across main targets and tests.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Appends Sunway math libs to math_libs and introduces a USE_SW ScaLAPACK::ScaLAPACK fallback target. |
| source/source_base/module_container/ATen/kernels/test/CMakeLists.txt | Skips container kernel unit tests on USE_SW. |
| source/source_base/module_container/test/CMakeLists.txt | Skips container unit tests on USE_SW. |
| source/source_hsolver/test/CMakeLists.txt | Skips a subset of HSOLVER tests on USE_SW (with a warning). |
| source/source_lcao/module_rt/test/CMakeLists.txt | Skips RT-TDDFT unit tests on USE_SW. |
| tools/README.md | Documents the new gtest_on_sunway tooling directory. |
| tools/gtest_on_sunway/gtest_on_sunway.sh | New script to build/install local GoogleTest and configure ABACUS tests offline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Files Changed:
Testing: