You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to provide a professional suggestion regarding the usage of ModuleBase::Timer.
It is recommended that timers be placed only at the beginning and end of a function, with the timer name consistent with the function name.
It is strongly discouraged to insert timers inside a function, especially using multiple timers within a single function.
If you find it necessary to time only a specific code segment inside a function rather than the entire function, this indicates that the corresponding code block should be refactored. In most cases, the logic being timed should be extracted into a separate function, with the timer applied at the start and end of this new function.
Adding unit tests for such extracted functions is further recommended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.