-
Notifications
You must be signed in to change notification settings - Fork 105
[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] Revert "BACKPORT: UPSTREAM: kbuild: move init/build-version to scripts/" #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReverts the earlier change that moved the kbuild build-version helper into scripts/, restoring the helper path to init/ to stay compatible with Deepin’s existing release tooling until those scripts are updated. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepin inclusion category: bugfix This reverts commit 1195f54. Our release scripts echo version to init/build-version: echo "echo $build_version_id" > init/build-verion (should sync to scripts) This change should be reverted after we modified the script. And this is different to upstream version, we will use the upstream version. Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
cf3d516 to
d90af56
Compare
deepin pr auto review我将对这个git diff进行全面的代码审查:
改进建议:
其他观察:
总体来说,这是一个合理的重构,将 build-version 脚本移动到更合适的位置,修改是完整且正确的。建议在提交信息中说明这次移动的原因,以帮助其他开发者理解这个改动。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lanlanxiyiji The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin inclusion
category: bugfix
This reverts commit 1195f54.
Our release scripts echo version to init/build-version:
echo "echo $build_version_id" > init/build-verion (should sync to scripts)
This change should be reverted after we modified the script.
Summary by Sourcery
Bug Fixes: