fix: DH-21616: use model text color instead of databar color for cell text #2629
Draft
gzh2003 wants to merge 3 commits intodeephaven:mainfrom
Draft
fix: DH-21616: use model text color instead of databar color for cell text #2629gzh2003 wants to merge 3 commits intodeephaven:mainfrom
gzh2003 wants to merge 3 commits intodeephaven:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2629 +/- ##
==========================================
+ Coverage 49.48% 49.77% +0.28%
==========================================
Files 772 774 +2
Lines 43738 43777 +39
Branches 11066 11262 +196
==========================================
+ Hits 21643 21788 +145
+ Misses 22077 21971 -106
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This was a stylistic choice. However, I agree that explicitly setting a color should override it. Does this code still maintain that choice, if I make a purple, or gradient bar with no explicit text color set, is the color still the same as it was? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For DH-21616. Previously,
DataBarCellRendererused the databar fill color for both the bar and the text, ignoring any explicit text color set viaTableFormat.color.Now calls
model.colorForCell()to check for an explicit text color. If one is set, it takes precedence over the databar color for text rendering. When no explicit text color is set, the text still inherits the databar color.