fix: DH-21744: Fix Advanced Filters in Pivots#1308
Open
vbabich wants to merge 3 commits intodeephaven:mainfrom
Open
fix: DH-21744: Fix Advanced Filters in Pivots#1308vbabich wants to merge 3 commits intodeephaven:mainfrom
vbabich wants to merge 3 commits intodeephaven:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes advanced filters in pivots by adding hover state management to the PivotFilterMouseHandler class. The changes implement mouse move tracking and mouse leave handling for pivot column source filter boxes.
Changes:
- Added
onMovemethod to track mouse movement and set hover state for column source filters - Added
onLeavemethod to clear hover state when the mouse leaves the grid - Implements logic to distinguish between column header area and regular filter bar area
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgodinez-dh
previously approved these changes
Feb 20, 2026
dgodinez-dh
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.