Get rid of Moveable<> class #285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
force-pushed
the
kosak_get-rid-of-moveable
branch
2 times, most recently
from
af55a71 to
3fade9f
Compare
kosak
force-pushed
the
kosak_get-rid-of-moveable
branch
from
68bad9e to
ba9f9eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** NOTE TO REVIEWERS ** this PR is downstream of #284 . That PR should be merged before you look at this PR.
The Moveable<> class was meant to make the code more disciplined and prevent code from accidentally holding on to a reference longer than necessary. But in practice it added more noise than clarity.