Skip to content

fix: person and company predicates #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ClemDoum wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: person and company predicates #8

ClemDoum wants to merge 1 commit into from

Conversation

@ClemDoum
Copy link

@ClemDoum ClemDoum commented May 17, 2024

Bug description

While training a Gazetteer on data with a person field and no other name field, I noticed that predicates like PartialIndexLevenshteinSearchPredicate: (3, best_looking_name, CorporationName) were wrongly generated as well as the expected PartialIndexLevenshteinSearchPredicate: (3, best_looking_name, Surname).

This happens because block_parts were not properly set when initialization of the WesternNameType depending on the WesternNameType.name_type

Changes

Fixed

  • when initializing WesternNameType, appropriately set the block_parts depending on the WesternNameType.name_type before calling the parent ParseratorType.__init__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ClemDoum