Conversation
Contributor
There was a problem hiding this comment.
As this is the most important file of the PR, comments explaining how you structured the grammar is important.
Contributor
|
Is this just the setup or is it implemented in the extension ? |
Contributor
|
Also, it might be better to remove the generated files and have the consumer download tree sitter locally to regenerate the files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a Tree-sitter grammar for MinML, enabling high-performance incremental parsing and laying the foundation for advanced editor support such as syntax highlighting, code folding, and symbol
navigation.
Key Changes
Verification
The implementation has been verified by running the Tree-sitter test suite
make tree-sitter-testand also manually checking the outputs of parsing example files withtree-sitter parse examples/XX-XX.m