Conversation
…de caching and admin boundaries
…aming approach The key improvements in this commit are: 1. Removed upfront collection of all building IDs and records 2. Added a semaphore to limit in-flight batches 3. Stream through `poiIndexDb` with a `RocksIterator` 4. Process buildings in batches of 1000 5. Drain completed futures inline to keep memory bounded 6. Added atomic counters to track submitted and collected batches 7. Final drain of all remaining futures This approach solves the memory issue with planet.pbf imports by: - Never collecting all building records into memory - Limiting concurrent processing - Streaming through the database - Draining futures continuously The implementation follows the pattern used in other methods like `processAdministrativeBoundariesFromIndex`, ensuring consistent memory management and parallel processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.