server: Use addrmgr.NetAddress for ban/whitelist.#3638
Merged
davecgh merged 1 commit intodecred:masterfrom Apr 10, 2026
Merged
Conversation
davecgh
force-pushed
the
server_netaddr_for_ban_and_whitelist
branch
from
44e1740 to
e7ef66b
Compare
davecgh
force-pushed
the
server_netaddr_for_ban_and_whitelist
branch
from
e7ef66b to
5d31339
Compare
davecgh
force-pushed
the
server_netaddr_for_ban_and_whitelist
branch
from
5d31339 to
465e79e
Compare
davecgh
force-pushed
the
server_netaddr_for_ban_and_whitelist
branch
from
465e79e to
cec584e
Compare
jrick
approved these changes
Apr 10, 2026
alexlyp
approved these changes
Apr 10, 2026
Currently, the whitelist and banning detection splits the host and port multiple times since the address previously hadn't been parsed yet. However, it is no longer necessary since the parsed address is now available as soon as the peer first connects. This updates the detection funcs to take the parsed address directly.
davecgh
force-pushed
the
server_netaddr_for_ban_and_whitelist
branch
from
cec584e to
0d37f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #3633.
Currently, the whitelist and banning detection splits the host and port multiple times since the address previously hadn't been parsed yet.
However, it is no longer necessary since the parsed address is now available as soon as the peer first connects.
This updates the detection funcs to take the parsed address directly.