server: Disconnect banned peers earlier. #3601
Merged
+46
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
server_early_ban
branch
from
7bb1e60 to
bd83043
Compare
jrick
approved these changes
Jan 20, 2026
Due to legacy reasons that no longer apply, the logic that handles banned peers currently happens after version negotiation has taken place. While there is nothing inherently wrong with it happening after negotiation, it does mean that it is doing additional work that is no longer strictly required. With that in mind, this refactors the logic that handles banned peers to happen immediately upon seeing new connections.
davecgh
force-pushed
the
server_early_ban
branch
from
bd83043 to
f18b111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to legacy reasons that no longer apply, the logic that handles banned peers currently happens after version negotiation has taken place. While there is nothing inherently wrong with it happening after negotiation, it does mean that it is doing additional work that is no longer strictly required.
With that in mind, this refactors the logic that handles banned peers to happen immediately upon seeing new connections.