fix(vton-modal): close button alignment in panel header (#602)#607
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X 버튼이 modal root에
absolute top-4 right-4floating button으로 떠 있어 ItemPanel 헤더의 "Virtual Try-On PoC" 텍스트와 vertical 정렬되지 않던 문제 해결.Changes
packages/web/lib/components/vton/VtonModal.tsx<button>(line 365-371) 제거import { X } from "lucide-react"제거<VtonItemPanel ... onClose={handleClose} />prop 전달packages/web/lib/components/vton/VtonItemPanel.tsxonClose: () => void추가flex items-center justify-between border-b border-white/10 px-4 py-3로 변경aria-label="Close VTON modal"유지 — E2E selector 호환)Verification
bun run lint→ 0 errors (<img>warning은 pre-existing, 본 PR 비관련)bun run tsc --noEmit→ 0 errors (vton files)bun run build→ PASShandleClose/ Escape key / backdrop click 동작 그대로 유지Test plan
@media md:)에서도 동일 동작 확인bun run buildfailure is NOT this PRLocal
bun run build가packages/web/app/api/v1/content/assets/plan/__tests__/route.test.ts:559의useResearchInCopy타입 mismatch로 실패합니다. 이는 dev pre-existing: #498 (feat(content-studio): AI-powered content generation pipeline) 머지된 시점부터 발생. 본 PR은 vton 파일만 건드리고 vton 한정 lint/tsc/test는 모두 PASS. content-studio 영역 fix는 별도 owner가 처리해야 함.Refs #602 (sub-PR #1 of 4)