refactor(connections): remove arbitrary field filtering from list tool#2856
Open
pedrofrxncx wants to merge 3 commits intomainfrom
Open
refactor(connections): remove arbitrary field filtering from list tool#2856pedrofrxncx wants to merge 3 commits intomainfrom
pedrofrxncx wants to merge 3 commits intomainfrom
Conversation
Replace server-side where/orderBy filtering with client-side search in the UI. This removes ~160 lines of in-memory query evaluation code and allows the storage layer to use explicit column selection instead of selectAll(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsSuggested: Prerelease ( React with an emoji to override the release type:
Current version:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ction list Keep only the storage-layer change: enumerate columns explicitly in ConnectionStorage.list() instead of using selectAll(). This excludes the unused `subtype` column and makes the query self-documenting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
1 issue found across 6 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/mesh/src/tools/connection/list.ts">
<violation number="1">
P2: `not` with multiple conditions yields NAND semantics (`!(A && B)`) rather than the typical logical NOT (`!A && !B`). If `not` is intended to be unary, add a guard ensuring `conditions.length === 1`; otherwise, if intent is "none match", use `!conditions.some(...)` instead.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
where/orderByevaluation fromCOLLECTION_CONNECTIONS_LISTtool (~160 lines of query evaluation code deleted)selectAll()with explicit column selection inConnectionStorage.list()(excludes unusedsubtypecolumn)useConnectionshook to call the tool directly instead of routing through genericuseCollectionListconnections.tsxandtool-set-selector.tsxTest plan
bun test apps/mesh/src/tools/connection/connection-tools.test.ts— 8/8 passbun run check— no new type errorsbun run lint— 0 errors🤖 Generated with Claude Code
Summary by cubic
Replace
selectAll()with explicit column selection inConnectionStorage.list()to narrow DB reads, drop the unusedsubtype, and make the query clearer.Written for commit d431bc9. Summary will update on new commits.