fix(ui): replace remaining client-side connection filtering with server-side#2850
Open
viktormarinho wants to merge 1 commit intomainfrom
Open
fix(ui): replace remaining client-side connection filtering with server-side#2850viktormarinho wants to merge 1 commit intomainfrom
viktormarinho wants to merge 1 commit intomainfrom
Conversation
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsSuggested: Patch ( React with an emoji to override the release type:
Current version:
|
77adb5f to
ee185c3
Compare
26a603d to
2bca2ab
Compare
Contributor
There was a problem hiding this comment.
3 issues found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/mesh/src/web/components/binding-selector.tsx">
<violation number="1" location="apps/mesh/src/web/components/binding-selector.tsx:68">
P2: Using the server-filtered query as `allConnections` breaks the “keep selected connection even if filtered out” fallback, since the selected item may no longer be present in the source list.</violation>
</file>
<file name="apps/mesh/src/web/routes/orgs/collection-detail.tsx">
<violation number="1" location="apps/mesh/src/web/routes/orgs/collection-detail.tsx:54">
P1: Filtering connections with `app_name = params.appSlug` mismatches how `$appSlug` is generated (`getConnectionSlug`), so valid detail routes can fail to resolve their connection.</violation>
</file>
<file name="apps/mesh/src/web/components/details/virtual-mcp/index.tsx">
<violation number="1" location="apps/mesh/src/web/components/details/virtual-mcp/index.tsx:144">
P1: Sibling instance matching no longer enforces canonical slug equality, so connections without `app_name` can incorrectly treat all non-virtual connections as siblings.
(Based on your team's feedback about using `getConnectionSlug()` as the canonical sibling identifier.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
2bca2ab to
73aab84
Compare
ee185c3 to
dfa26f9
Compare
73aab84 to
1489310
Compare
dfa26f9 to
665bcf1
Compare
1489310 to
2e41d26
Compare
665bcf1 to
aa69418
Compare
7566656 to
77e33b5
Compare
aa69418 to
e81f29c
Compare
77e33b5 to
b780ff4
Compare
d76a990 to
8c4b18a
Compare
b4a1f37 to
860bdbc
Compare
8c4b18a to
e32d090
Compare
Base automatically changed from
viktormarinho/server-side-conn-4-registry-server-side
to
main
March 24, 2026 21:24
64b6271 to
2185826
Compare
…er-side filters
Replace useConnections() + getConnectionSlug() lookups with
useConnections({ filters: [{ column: "app_name", value: appSlug }] })
for targeted server-side queries. Use binding: "WORKFLOW" and
binding: "LLM" for binding-based filtering instead of loading all
connections and filtering client-side.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2185826 to
a340e12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useConnections()+getConnectionSlug()lookups withuseConnections({ filters: [{ column: "app_name", value: appSlug }] })in connection detail, virtual-mcp detail, workflow hooks, and collection detailbinding: "WORKFLOW"for workflow binding connection hookbinding: "LLM"in private-registry plugin components (monitor-configuration, registry-settings)binding-selectorandmcp-configuration-formfor string binding typesincludeVirtualoption to tool-set-selectorStack
PR 5/5 — Remaining filters (base: PR 4)
Test plan
🤖 Generated with Claude Code
Summary by cubic
Replaced remaining client-side connection filtering with server-side
useConnectionsqueries byapp_nameorbindingacross connection, virtual MCP, workflow, collection, and private‑registry views to reduce over‑fetching and keep results consistent. Removed Binder‑based filtering and standardized WORKFLOW/LLM lookups.useConnections({ filters: [{ column: "app_name", value: appSlug }] })in connection, virtual MCP, workflow, and collection views; removegetConnectionSlug()lookups.useConnections({ binding: "WORKFLOW" })in workflow hooks anduseConnections({ binding: "LLM" })in private‑registry components.binding-selectorand MCP configuration form to use server‑sidebindingfiltering; drop Binder support, fall back toapp_namefor unknown registry types, and passbindingNamefrom plugins (project-plugins-form).useBindingConnectionsand related tests; in connection settings, detect MCP by checking forMCP_CONFIGURATION*tools.tool-set-selector, passincludeVirtual: !!excludeVirtualMcpIdand filter out only the excluded virtual connection.Written for commit a340e12. Summary will update on new commits.