fix: resolve xml dir for non root setup#2434
Open
yaroslavborbat wants to merge 2 commits into
Open
Conversation
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
yaroslavborbat
requested review from
nevermarine and
universal-itengineer
as code owners
diafour
reviewed
Jun 2, 2026
Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com> Signed-off-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
diafour
approved these changes
Jun 2, 2026
diafour
reviewed
Jun 2, 2026
| func resolveXMLDir() (string, error) { | ||
| _, err := os.Stat(xmlDirNonRoot) | ||
| if err == nil { | ||
| return xmlDirNonRoot |
Member
There was a problem hiding this comment.
Suggested change
| return xmlDirNonRoot | |
| return xmlDirNonRoot, nil |
diafour
requested changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolve xml dir for non root setup
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries