e2e: add blockdevice regression scenarios#235
Merged
viktor-karpochev merged 2 commits intomainfrom Apr 20, 2026
Merged
Conversation
Contributor
E2E Smoke Tests Results ✅Module: sds-node-configurator
Tests were executed via storage-e2e (TestSdsNodeConfigurator: Common Scheduler Extender, then Sds Node Configurator). Artifacts: Test logs are available in workflow artifacts. |
szhem
reviewed
Apr 16, 2026
szhem
left a comment
szhem
left a comment
There was a problem hiding this comment.
Review Summary
| Severity | Count |
|---|---|
| Critical | 0 |
| High | 0 |
| Medium | 4 |
| Low | 1 |
| Nit | 1 |
Positive Observations
- Tests are well-structured with clear step-by-step
By()annotations and informative assertion messages - Graceful handling of webhook protection in the manual BD creation test (
IsForbidden/IsInvalid→ graceful skip/verify) restartSDSNodeConfiguratorAgentOnNodeis a clean, reusable helper covering the full pod lifecycle (delete → gone → replacement running+ready)AfterEachcleanup in the Size Reduction test correctly strips finalizers before LVG deletion- README documentation accurately describes each scenario and its assertions
Eventuallytimeouts are appropriate for e2e (5-10 min with 10-15s polling)
kkozoriz
previously approved these changes
Apr 17, 2026
Add the blockdevice disappearance, shrink, and manual mutation coverage on top of the latest main branch changes while keeping the cleanup hardening and failure-only shrink diagnostics from review follow-ups. Signed-off-by: Viktor Karpochev <viktor.karpochev@flant.com> Made-with: Cursor
viktor-karpochev
force-pushed
the
e2e/vkarpochev-blockdevice-tests-only
branch
from
3691328 to
1d99da8
Compare
Use strconv.Itoa instead of fmt.Sprintf for the random suffix in the manual BlockDevice test to address the remaining style nit without changing behavior. Signed-off-by: Viktor Karpochev <viktor.karpochev@flant.com> Made-with: Cursor
kkozoriz
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlockDeviceis removed after its backing disk disappearsLVMVolumeGroupdegrades after replacing the backing block device with a smaller oneBlockDevicecreation and status mutations, and document them ine2e/README.mdTest plan
cd e2e && go test ./tests -run TestDoesNotExist -count=0Made with Cursor