Skip to content

add check go mod tidy ran before commit #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
name212 merged 1 commit into from
Apr 29, 2026
Merged

add check go mod tidy ran before commit #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/check_pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ jobs:
name: Get PR labels
id: pr-labels
uses: joerick/pr-labels-action@v1.0.9

- name: Check make go-deps/tidy ran before commit
run: make go-deps/ci/check/no-tidy

- name: Run tests
run: |
Expand Down
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ go-deps/update: go-installed
go-deps/tidy: go-installed
go mod tidy && cd ./tests && go mod tidy && cd ../examples/cobra && go mod tidy

go-deps/ci/check/no-tidy: go-installed go-deps/tidy
git diff --exit-code

test: go-installed docker-installed bin/kind
./hack/run_tests.sh
$(MAKE) clean/test
Expand Down
Loading