Removing duplicate websocket sharp#6177
Removing duplicate websocket sharp#6177ProteanCoding wants to merge 2 commits intodecentraland:devfrom
Conversation
|
Are you sure this is correct? If you remove |
|
Sorry I meant to keep this as |
|
I am indeed not sure this is correct. |
|
Unfortunately, you can't run our automated checks as an external contributor, and I would need to move your branches to our repo so the CI will pick it up. I'm a bit lost with all the PRs you have opened ;) Regarding the duplicate WebSocket Sharp library, I'm sure the project will not compile. Just to confirm, I pulled your branch and opened it in Unity, and there are quite a few compiler errors. Also, our CI has failed with compilation errors. As a suggestion, it would be good to test your changes locally before opening a PR to catch issues like this. |
|
Yes as I wrote, I meant to keep this one in |
|
So I've been reviewing the train of thought regarding my original attempt at removal of the whole For unity-renderer/browser-interface/Makefile Line 72 in 481ffa9 Thus I assumed the unity-explorer project was pulled in at that point, and that files remaining in the unity-renderer folder were left-over from a transfer to that project.
I now see that this in fact "pulls the result of the Talk about misnomers !! |
|
I hadn't even compiled that folder at that point, as it needs Unity 20 |

What does this PR change?
This is to fix code duplication.
This code has been maintained here: 9ad1866
But a different version has been used here: https://github.com/decentraland/unity-renderer/blob/dev/.circleci/config.yml#L18