Skip to content

test: lift coverage on jvm-orphan-reaper (36->97%) and minimal-dap (85->92%) #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debugmcpdev merged 1 commit into from
May 15, 2026
Merged

test: lift coverage on jvm-orphan-reaper (36->97%) and minimal-dap (85->92%) #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/utils/jvm-orphan-reaper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ export async function listTaggedJvms(): Promise<TaggedJvm[]> {
}
}

async function listLinux(): Promise<TaggedJvm[]> {
/** @internal Exposed for unit tests; not part of the public module API. */
export async function listLinux(): Promise<TaggedJvm[]> {
let entries: string[];
try {
entries = await fs.readdir('/proc');
Expand All @@ -144,7 +145,8 @@ async function listLinux(): Promise<TaggedJvm[]> {
return result;
}

async function listDarwin(): Promise<TaggedJvm[]> {
/** @internal Exposed for unit tests; not part of the public module API. */
export async function listDarwin(): Promise<TaggedJvm[]> {
// -ww disables column truncation; otherwise long java cmdlines lose the
// -D markers we depend on. -A lists all users' processes (we filter by
// owner_pid liveness anyway).
Expand All @@ -166,7 +168,8 @@ async function listDarwin(): Promise<TaggedJvm[]> {
return result;
}

async function listWindows(): Promise<TaggedJvm[]> {
/** @internal Exposed for unit tests; not part of the public module API. */
export async function listWindows(): Promise<TaggedJvm[]> {
// Get-CimInstance is the modern path; wmic is deprecated and missing on
// fresh Windows 11 installs. ConvertTo-Json -Compress keeps stdout small.
// -NoProfile skips loading user profile scripts (faster, more deterministic).
Expand Down Expand Up @@ -206,7 +209,8 @@ async function listWindows(): Promise<TaggedJvm[]> {
return result;
}

function parseArgs(pid: number, args: string[]): TaggedJvm | null {
/** @internal Exposed for unit tests; not part of the public module API. */
export function parseArgs(pid: number, args: string[]): TaggedJvm | null {
let hasMarker = false;
let ownerPid = -1;
let sessionTag = '';
Expand Down Expand Up @@ -238,7 +242,8 @@ export function isPidAlive(pid: number): boolean {
}
}

function defaultKill(pid: number): boolean {
/** @internal Exposed for unit tests; not part of the public module API. */
export function defaultKill(pid: number): boolean {
try {
process.kill(pid, 'SIGKILL');
return true;
Expand Down
Loading
Loading