CPU usage change #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is on my computer, so I don't know if anyone else notices or cares, but the script/app would constantly take 1% of my CPU. That doesn't sound like much, but I have well over 100 other processes (499 at this minute, actually) that also want to use CPU and if they each took 1%, the computer wouldn't be usable. In looking at the "CPU time" column in Task Manager, I can see that it rivals my antivirus software for the amount of total CPU it's using. See the attached changes. I am not proposing these exact changes get merged in but I figured it was easier to show what I did with a pull request than an Issue... I take out the WinWait and look for the window after a hard-coded (10 seconds) amount of time. Obviously, if we thought this was a good idea, that would be a configurable amount of time. After making these changes, the CPU now sits around .03% (as seen in Process Explorer).
Owner
|
Hmmmm, I haven't noticed an issue and nobody else has reported it. Using Process Explorer I see it hovers around 0.07%, although maybe my machine has more CPU cores than yours. I'll do some experimenting and see what I find. Thanks for the heads up 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on my computer, so I don't know if anyone else notices or cares, but the script/app would constantly take 1% of my CPU. That doesn't sound like much, but I have well over 100 other processes (499 at this minute, actually) that also want to use CPU and if they each took 1%, the computer wouldn't be usable. In looking at the "CPU time" column in Task Manager, I can see that it rivals my antivirus software for the amount of total CPU it's using.
See the attached changes. I am not proposing these exact changes get merged in but I figured it was easier to show what I did with a pull request than an Issue... I take out the WinWait and look for the window after a hard-coded (10 seconds) amount of time. Obviously, if we thought this was a good idea, that would be a configurable amount of time.
After making these changes, the CPU now sits around .03% (as seen in Process Explorer).