Add API filter to retrieve only not completed matches#90
Open
grichet wants to merge 1 commit intodeStrO:masterfrom
Open
Add API filter to retrieve only not completed matches#90grichet wants to merge 1 commit intodeStrO:masterfrom
grichet wants to merge 1 commit intodeStrO:masterfrom
Conversation
|
+1 for this @deStrO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Toornament API retrieve only the 100 first matches if you don't add a pagination filter, it sometimes retrieve only completed matches. (e.g 120 matches on 140 are completed, retrieve only completed matches and eBot don't display any match).
To prevent that, you should had the 'has_result' filter to '0', to retrieve only pending matches.
In a perfect world you should handle a pagination (in case more than a hundred matches were not completed/pending).
have a nice day ;)