feat(style): use high-contrast themes for code blocks #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🌐 Fork Preview for PR #538 https://pr-538.ddev-com-fork-previews.pages.dev This preview updates automatically when you push changes to your fork. |
Member
|
There's no stopping you! |
tyler36
approved these changes
Feb 9, 2026
Contributor
tyler36
left a comment
tyler36
left a comment
There was a problem hiding this comment.
Looks fine to me, although I'm a life-long dark themed user.
I did note that Google Chrome's Lighthouse complained a lot about the codeblocks in light-mode.
Background and foreground colors do not have a sufficient contrast ratio.
Member
Author
|
Thanks @tyler36 ! I switched to |
stasadev
changed the title
Contributor
|
Thank you @stasadev . Lighthouse seems happier with |
|
PR closed. The Cloudflare Pages preview is no longer updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
I don't like that we have the same Nord color scheme for code blocks in both light/dark modes.
Comments in the Nord theme have poor contrast.
How This PR Solves The Issue
Uses
github-light-high-contrastfor light andgithub-dark-high-contrastfor dark, see https://shiki.style/themesManual Testing Instructions
Before:
https://ddev.com/get-started/ (Linux)
After:
https://pr-538.ddev-com-fork-previews.pages.dev/get-started/ (Linux)
Before:
https://ddev.com/get-started/ (Windows)
After:
https://pr-538.ddev-com-fork-previews.pages.dev/get-started/ (Windows)
Before:
https://ddev.com/blog/podman-and-docker-rootless/#installing-podman
After (note that comments have better visibility):
https://pr-538.ddev-com-fork-previews.pages.dev/blog/podman-and-docker-rootless/#installing-podman
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes