-
Notifications
You must be signed in to change notification settings - Fork 15
EBL 3.0: SD-2434: Add metadata to correlate TransportDocuments #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -475,6 +475,8 @@ components: | |
| properties: | ||
| document: | ||
| $ref: '#/components/schemas/TransportDocument' | ||
| transportDocumentReplacements: | ||
| $ref: '#/components/schemas/TransportDocumentReplacements' | ||
| issueTo: | ||
| $ref: '#/components/schemas/IssueToParty' | ||
| eBLVisualisationByCarrier: | ||
|
|
@@ -489,6 +491,60 @@ components: | |
| - document | ||
| - issueTo | ||
| - issuanceManifestSignedContent | ||
|
|
||
| TransportDocumentReplacements: | ||
| type: object | ||
| title: Transport Document Replacements | ||
| description: | | ||
| This object provides the possibility to link the issued `Transport Document` to one or more previously issued `Transport Document(s)`. | ||
|
|
||
| If this issuance request is the result of a previous **Surrender for Amendments** (because of an update to the `Transport Document`), the `oldTransportDocumentReferences` list would contain a single `transportDocumentReference` (and optionally a `transportDocumentSubReference`). | ||
|
|
||
| If the issued `Transport Document` is a "combine" of multiple `Transport Documents`, the `oldTransportDocumentReferences` list would contain the `transportDocumentReferences` being combined into the issued `Transport Document`. | ||
|
|
||
| The issued `Transport Document` can also be part of a split. In this case, the `newTransportDocumentReferences` list would contain all `transportDocumentReferences` that the `Transport Document(s)` specified in `oldTransportDocumentReferences` have been split into. | ||
|
|
||
| **Note:** If provided it should be considered as metadata and is not part of the `issuanceManifestSignedContent`. | ||
|
HenrikHL marked this conversation as resolved.
|
||
| properties: | ||
| oldTransportDocumentReferences: | ||
| type: array | ||
| description: | | ||
| A list of `transportDocumentReference` values and optional `transportDocumentSubReference` values from which the issued `Transport Document` originated. | ||
| If the list contains more than one item, the issuance is the result of a "combine" of multiple `Transport Documents`. | ||
| This property is only relevant if a previous **Surrender for Amendments** has been performed. | ||
|
HenrikHL marked this conversation as resolved.
|
||
| items: | ||
| $ref: '#/components/schemas/TransportDocumentRelation' | ||
| newTransportDocumentReferences: | ||
| type: array | ||
| description: | | ||
| A list of `transportDocumentReference` values and optional `transportDocumentSubReference` values into which the issued `Transport Document` has been split. | ||
| This property is only relevant if a previous **Surrender for Amendments** has resulted in a split of `Transport Documents`. | ||
| items: | ||
| $ref: '#/components/schemas/TransportDocumentRelation' | ||
|
Comment on lines
+495
to
+523
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1. Empty replacements allowed TransportDocumentReplacements has no required properties and no minItems, so
transportDocumentReplacements: {} or empty arrays validate even though the description says it
links to one or more Transport Documents, producing ambiguous/invalid lineage data.
Agent Prompt
|
||
|
|
||
| TransportDocumentRelation: | ||
| type: object | ||
| title: Transport Document Relation | ||
| description: | | ||
| An object linking a `transportDocumentReference` with an optional `transportDocumentSubReference`. | ||
| properties: | ||
| transportDocumentReference: | ||
| type: string | ||
| pattern: ^\S(?:.*\S)?$ | ||
| maxLength: 20 | ||
| description: | | ||
|
HenrikHL marked this conversation as resolved.
|
||
| A unique number allocated by the shipping line to the `Transport Document` and the main number used for the tracking of the status of the shipment. | ||
| example: HHL71800000 | ||
| transportDocumentSubReference: | ||
| type: string | ||
| pattern: ^\S(?:.*\S)?$ | ||
| maxLength: 100 | ||
| description: | | ||
| Additional reference that can be optionally used alongside the `transportDocumentReference` in order to distinguish between versions of the same `Transport Document`. | ||
| example: Version_1 | ||
| required: | ||
| - transportDocumentReference | ||
|
|
||
| SupportingDocument: | ||
| type: object | ||
| title: Supporting Document | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.