chore: Refine tool configs, personas, and skills

.config/jp/tools/src/fs/modify_file.rs

@@ -802,7 +802,9 @@ fn apply_changes<R: ProcessRunner>(
         Some(true) => {}
         Some(false) => {
             return Err(
-                "`apply_changes` inquiry was answered with `false`. Changes discarded.".into(),
+                "The proposed file changes were reviewed and rejected. Changes were not applied. \
+                 You may retry with different changes."
+                    .into(),
             );
         }
         None => {

.jp/config/personas/dev.toml

@@ -8,8 +8,9 @@ extends = [
 ]
 
 [conversation.tools]
-fs_move_file.questions.move_dirty_file.answer = true
+fs_create_file.questions.overwrite_file.answer = true
 fs_modify_file.questions.modify_dirty_file.answer = true
+fs_move_file.questions.move_dirty_file.answer = true
 
 [[conversation.attachments]]
 type = "cmd"

.jp/config/personas/stager.toml

@@ -7,6 +7,10 @@ extends = [
     "../skill/project-discourse.toml",
 ]
 
+[conversation.tools]
+'*' = { enable = false, run = "ask" }
+git_stage_patch.questions.stage_changes.answer = true
+
 [assistant.system_prompt]
 strategy = "append"
 separator = "paragraph"
@@ -28,7 +32,6 @@ diff --cached`. A summary of what was staged and why this group was picked is en
 
 [conversation]
 title.generate.auto = false
-tools.'*' = { enable = false, run = "unattended" }
 
 [[conversation.attachments]]
 type = "cmd"

.jp/config/skill/edit-files.toml

@@ -12,8 +12,10 @@ the current project. The following tools help you with this:
 
 You should consider token-usage when using these tools:
 
-- Do NOT re-create files that already exist, unless the majority of the file's content will be \
+- DO NOT re-create files that already exist, unless the majority of the file's content will be \
 replaced.
+- DO NOT delete-and-recreate files when you want to MOVE them to a new location, use \
+`fs_move_file` instead.
 - DO USE `fs_modify_file` to mutate multiple files at once, using multiple patterns if applicable. \
 This is faster and more token-efficient than calling `fs_modify_file` multiple times for \
 single-file mutations.

.jp/config/skill/git-reading.toml

@@ -7,8 +7,8 @@ value = """
 You have been given the git-reading skill. You are an expert at reading and navigating git history \
 and diffs. The following tools help you with this:
 
-- git_diff: Diff the git repository, with a required `status` parameter: `"staged"`, `"unstaged"`, \
-or `"all"`.
+- git_diff: Diff the git repository, with a required `status` parameter: `"staged"` or `"unstaged"`. \
+Output is truncated per file; use the `paths` parameter to see full diffs for specific files.
 - git_log: Search the commit history. Supports filtering by message text, file paths, date range, \
 and result count.
 - git_show: Show commit details (message and changed file stats). Does NOT include actual diff \

.jp/mcp/tools/cargo/expand.toml

@@ -1,7 +1,6 @@
 [conversation.tools.cargo_expand]
 enable = false
 run = "unattended"
-style.inline_results = "off"
 
 source = "local"
 command = "just serve-tools {{context}} {{tool}}"
@@ -19,6 +18,11 @@ Expand a top-level item:
 ```
 """
 
+[conversation.tools.cargo_expand.style]
+inline_results = "off"
+results_file_link = "off"
+parameters = "function_call"
+
 [conversation.tools.cargo_expand.parameters.package]
 summary = "Package to find the item in, required if working with a workspace."
 type = "string"

.jp/mcp/tools/fs/modify_file.toml

@@ -58,8 +58,8 @@ Use regex with capture groups:
 ```
 """
 
-questions.apply_changes.target = "assistant"
-# questions.apply_changes.answer = true
+# questions.apply_changes.target = "assistant"
+questions.apply_changes.answer = true
 
 [conversation.tools.fs_modify_file.style]
 parameters = "just serve-tools {{context}} {{tool}}"

.jp/mcp/tools/git/diff.toml

@@ -6,6 +6,11 @@ style.inline_results = "full"
 source = "local"
 command = "just serve-tools {{context}} {{tool}}"
 summary = "Show the diff of changes in the git repository, filtered by staging status."
+description = """
+Returns a per-file summary of changes with truncated diffs. Each file's diff \
+is capped at 50 lines. If a file is truncated, re-run with `paths` set to \
+that file to see its full diff.
+"""
 
 examples = """
 Diff all unstaged changes:
@@ -22,11 +27,6 @@ Diff staged changes:
 ```json
 {"status": "staged", "paths": ["src/"]}
 ```
-
-Diff all changes (staged + unstaged combined):
-```json
-{"status": "all"}
-```
 """
 
 [conversation.tools.git_diff.parameters.paths]
@@ -36,13 +36,12 @@ summary = "Optional list of paths to restrict the diff to. If omitted, diffs the
 
 [conversation.tools.git_diff.parameters.status]
 type = "string"
-enum = ["all", "staged", "unstaged"]
+enum = ["staged", "unstaged"]
 required = true
 summary = "Which changes to include in the diff."
 description = """
 - `"staged"`: changes in the index that differ from HEAD (HEAD vs index).
 - `"unstaged"`: changes in the working tree that differ from the index (index vs working tree).
-- `"all"`: all changes from HEAD, regardless of staging (HEAD vs working tree).
 
 A staged change will NOT appear in the `"unstaged"` diff and vice versa.
 """

.jp/mcp/tools/git/stage_patch.toml

@@ -1,7 +1,6 @@
 [conversation.tools.git_stage_patch]
 enable = "explicit"
 run = "unattended"
-style.inline_results = "full"
 
 source = "local"
 command = "just serve-tools {{context}} {{tool}}"
@@ -23,8 +22,10 @@ Stage patches across multiple files:
 ```
 """
 
-# questions.stage_changes.target = "assistant"
-questions.stage_changes.answer = true
+[conversation.tools.git_stage_patch.style]
+inline_results = "full"
+results_file_link = "off"
+parameters = "off"
 
 [conversation.tools.git_stage_patch.parameters.patches]
 type = "array"

.jp/mcp/tools/github/code_search.toml

@@ -23,6 +23,11 @@ Search in another repository:
 ```
 """
 
+[conversation.tools.github_code_search.style]
+inline_results = "off"
+results_file_link = "off"
+parameters = "function_call"
+
 [conversation.tools.github_code_search.parameters.repository]
 type = "string"
 summary = "Repository to search for code."

.jp/mcp/tools/web/fetch.toml

@@ -10,6 +10,11 @@ examples = """
 ```
 """
 
+[conversation.tools.web_fetch.style]
+parameters = "function_call"
+inline_results = "off"
+results_file_link = "full"
+
 [conversation.tools.web_fetch.parameters.url]
 type = "string"
 required = true