Conversation
The `--tmp` flag on `conversation edit` now toggles when invoked without a value: if an expiration is already set it is removed; if none is set, the conversation is marked to expire immediately (on the next cleanup run). Previously, `--tmp` without a value silently set expiration to `Duration::ZERO`, which was undocumented and didn't allow toggling. The flag also now accepts `now` as an alias for immediate expiration alongside standard duration strings like `1h` or `30m`, handled by the new `ExpirationDuration` parsing type. Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--tmpflag onconversation editnow toggles when invoked without a value: if an expiration is already set it is removed; if none is set, the conversation is marked to expire immediately (on the next cleanup run).Previously,
--tmpwithout a value silently set expiration toDuration::ZERO, which was undocumented and didn't allow toggling.The flag also now accepts
nowas an alias for immediate expiration alongside standard duration strings like1hor30m, handled by the newExpirationDurationparsing type.