Skip to content

Conversation

@gg46ixav
Copy link
Collaborator

@gg46ixav gg46ixav commented Nov 11, 2025

  • removed .vscode folder
  • removed BACKLOG.md and moved it to issue #32
  • moved nextcloudclient/upload.py to databusclient/rclone_wrapper/upload.py
  • removed nextcloudclient folder

Summary by CodeRabbit

  • Chores
    • Removed development environment configuration files.
    • Removed internal project documentation.
    • Updated dependency import source.

@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

📝 Walkthrough

Walkthrough

Removed VSCode workspace configuration files containing debugging and Python testing settings, deleted a backlog document, and updated the CLI module to import the upload wrapper from a different source module.

Changes

Cohort / File(s) Summary
VSCode Configuration
.vscode/launch.json, .vscode/settings.json
Removed debugging configurations for pytest and Python testing workspace settings
Documentation
BACKLOG.md
Removed backlog document including feature notes, known issues, and related SPARQL queries
CLI Module
databusclient/cli.py
Changed upload module import source from nextcloudclient to databusclient.rclone_wrapper

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Verify that databusclient.rclone_wrapper provides the same public interface as the previous nextcloudclient upload module to ensure no breaking changes to CLI functionality.

Possibly related PRs

Suggested reviewers

  • Integer-Ctrl

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check ✅ Passed The title accurately summarizes the main changes: removal of .vscode config files, deletion of BACKLOG.md, and relocation of upload.py to a new module.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gg46ixav gg46ixav changed the title cleanup Remove .vscode config, BACKLOG.md and move upload.py Nov 11, 2025
@Integer-Ctrl Integer-Ctrl self-assigned this Nov 24, 2025
@Integer-Ctrl
Copy link
Contributor

Hi @gg46ixav!

Why the cleanup? I agree the repo is messy and could use some organization, but I'm curious why you decided to start this now. From what I saw, you mainly changed a path and deleted three files. Is there a specific reason for removing them besides the fact that they’re currently unused?

Just asking out of interest 👍

@gg46ixav
Copy link
Collaborator Author

Hi @gg46ixav!

Why the cleanup? I agree the repo is messy and could use some organization, but I'm curious why you decided to start this now. From what I saw, you mainly changed a path and deleted three files. Is there a specific reason for removing them besides the fact that they’re currently unused?

Just asking out of interest 👍

The cleanup was assigned to me by @Vehnem. The vscode folder does obviously not belong in the repo. The Backlog file adds no functionality - it is just info which was moved to an issue. The upload.py was moved because it looked like there were 2 existing clients (one especially for the nextcloud) which is not the case.

@Integer-Ctrl Integer-Ctrl merged commit 0235055 into main Nov 24, 2025
3 checks passed
@Integer-Ctrl Integer-Ctrl deleted the cleanup branch December 9, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants