Skip to content

Conversation

@maxdml
Copy link
Collaborator

@maxdml maxdml commented Dec 8, 2025

address #203

Copy link
Member

@kraftp kraftp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxdml
Copy link
Collaborator Author

maxdml commented Dec 15, 2025

Let's also add this to the Conductor-side tests (https://github.com/dbos-inc/dbos-conductor/blob/927ae5b5234f5759c228b8c9341798d3333cf948/tests/test_conductor.py#L506)

The conductor test already runs with a Go app. Am I missing something?

Screenshot 2025-12-15 at 12 24 07

@kraftp
Copy link
Member

kraftp commented Dec 15, 2025

Let's also add this to the Conductor-side tests (https://github.com/dbos-inc/dbos-conductor/blob/927ae5b5234f5759c228b8c9341798d3333cf948/tests/test_conductor.py#L506)

The conductor test already runs with a Go app. Am I missing something?
Screenshot 2025-12-15 at 12 24 07

Look at the code--the test is skipped

@maxdml
Copy link
Collaborator Author

maxdml commented Dec 15, 2025

Let's also add this to the Conductor-side tests (https://github.com/dbos-inc/dbos-conductor/blob/927ae5b5234f5759c228b8c9341798d3333cf948/tests/test_conductor.py#L506)

The conductor test already runs with a Go app. Am I missing something?
Screenshot 2025-12-15 at 12 24 07

Look at the code--the test is skipped

Indeed. Here it is: https://github.com/dbos-inc/dbos-conductor/pull/71

@maxdml
Copy link
Collaborator Author

maxdml commented Dec 16, 2025

Note that the conductor PR will need this one to be merged first (conductor checks out the latest main branch of the Go SDK)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants