Skip to content

Fix completion crash when tables are created during refresh#1591

Open
shgol wants to merge 1 commit intodbcli:mainfrom
shgol:main
Open

Fix completion crash when tables are created during refresh#1591
shgol wants to merge 1 commit intodbcli:mainfrom
shgol:main

Conversation

@shgol
Copy link
Copy Markdown

@shgol shgol commented May 3, 2026

Description

Fixes race in completer_refresh thread when a table is created in between extend_relations and extend_columns, which causes a KeyError on accessing the relname key.

closes #1590

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install).
  • I verified that my changes work as expected (this may include manually testing them in your local environment, or in other available environments). Cross this out if not relevant (for example, if you're making a documentation change).
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

completion_refresh thread crashes with KeyError

1 participant