Skip to content

Revert suppression of sqlglotrs warnings#1718

Merged
rolandwalker merged 1 commit intomainfrom
RW/revert-sqlglotrs-warnings-suppression
Mar 20, 2026
Merged

Revert suppression of sqlglotrs warnings#1718
rolandwalker merged 1 commit intomainfrom
RW/revert-sqlglotrs-warnings-suppression

Conversation

@rolandwalker
Copy link
Contributor

Description

Revert suppression of sqlglotrs warnings, since we are committed to sqlglot 30.x, which has a better fix upstream.

Reverts #1710.

xref tobymao/sqlglot#7290

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker self-assigned this Mar 17, 2026
@github-actions
Copy link

No correctness or security issues found in this PR diff.

Finding (test gap)

  1. Missing regression test for import-time warning behavior after removing suppression in:

    Action: add a test that imports these modules (or CLI entrypoint) under the pinned sqlglot[c] ~= 30.0.0 and asserts no UserWarning is emitted. This protects against future upstream regressions.

Assumption

  • This change is safe as long as dependency resolution continues to enforce sqlglot 30.x from pyproject.toml.

Verification gap

  • I could not run tests in this environment because pytest/uv are unavailable.

since we are committed to sqlglot 30.x, which has a better fix upstream
@rolandwalker rolandwalker force-pushed the RW/revert-sqlglotrs-warnings-suppression branch from d65ce3a to 00ddf55 Compare March 20, 2026 19:52
@rolandwalker rolandwalker merged commit dc4d2a3 into main Mar 20, 2026
8 checks passed
@rolandwalker rolandwalker deleted the RW/revert-sqlglotrs-warnings-suppression branch March 20, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants