Accept multiple --execute options and run each specified query in turn
#1476
+58
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and run each specified query in turn. The current behavior is to accept multiple --execute options, but to only execute the last one: a bug. Since there are multiple values, we can also support --throttle, per the discussion in #1460. One inconsistency between STDIN and --execute is that --execute does not support warning on destructive queries. This should probably be resolved in the direction of removing the warning from scripts on STDIN.
Contributor
|
What is the benefit of multiple executes over running multiple queries within a single execute like you would normally? I.e. vs Unless there is a specific use case that seems unnecessary. My original comment was around the fact that you could technically have the throttle affect the multiple queries passed at once, since we parse the queries one by one anyway. |
Contributor
Author
|
The benefits are:
|
Contributor
Unclear why you need multiple -e params to unify the batch modes? RE: the multiple -e bug, I'd lean towards checking for that scenario and erroring vs adding it in as functionality to avoid the bug. The behavior of accepting multiple is the same for all "basic" options, so we'd be selectively changing that in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accept multiple
--executeoptions and run each specified query in turnThe current behavior is to accept multiple
--executeoptions, but to only execute the last one: a bug.Since there are multiple values, we can also support
--throttle, per the discussion in #1460.One inconsistency between STDIN and
--executeis that--executedoes not support warning on destructive queries. This should probably be resolved in the direction of removing the warning from scripts on STDIN.Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.