Fix perform-mode generic output sinks for graph pipelines#1036
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Patrick Laing <patricklaing@gmail.com>
d8e665a to
f3688aa
Compare
Summary
Fix perform-mode generic output sinks, including NDI, when running generated
graph pipelines.
The frame processor now tracks the primary graph output sink and routes
packets from that sink through the normal frame-output path. That makes
generic
output_sinksreceive the canonical perform-mode stream instead ofonly incrementing the frame counter.
Root Cause
Graph-mode output was read through
get_packet_from_sink(), but that pathbypassed
_on_frame_output(). As a result, WebRTC could receive frames whilegeneric output sinks such as NDI did not get fanned out frames in perform
mode.
Changes
mode pipelines.
_on_frame_output().Validation
uv run pytest tests/test_frame_processor_sinks.py