dinit-check: fix null dereference on "consumer-of: non-existent" and an igr-test for it#545
Open
mobin-2008 wants to merge 2 commits intodavmac314:masterfrom
Open
dinit-check: fix null dereference on "consumer-of: non-existent" and an igr-test for it#545mobin-2008 wants to merge 2 commits intodavmac314:masterfrom
mobin-2008 wants to merge 2 commits intodavmac314:masterfrom
Conversation
Get the value of "consumer-of" property by using the service name instead of using the service pointer which is null in this context.
mobin-2008
added
Bug/Bugfix
A-Importance: Normal
C-dinit-check
Check for dinit-check output when it encounters a non-existent service in the value of "consumer-of".
mobin-2008
force-pushed
the
fix_nullptr_derefrence
branch
from
cb77e43 to
488772f
Compare
mobin-2008
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was writing a service for my Dinit instance and then I saw a segfault in the output of the dinit-check command. For example:
I fixed the null dereference issue causing the segfault, see the first commit and also included a igr-test to make sure it always works correctly.