Skip to content

Please consider the following formatting changes to #14389 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 4 commits into from
Closed

Please consider the following formatting changes to #14389 #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
507d171
Add some more O2 settings to --setO2Settings of standalone benchmark
davidrohr Jun 10, 2025
f4a6dd7
GPU Standalone: No need for warmup iteration of double-pipeline with …
davidrohr Jun 10, 2025
b17bb4a
GPU Standalone: CI build should use -Werror
davidrohr Jun 11, 2025
8a09be3
Please consider the following formatting changes
alibuild Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion GPU/GPUTracking/Standalone/Benchmark/standalone.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,14 @@ int32_t ReadConfiguration(int argc, char** argv)
configStandalone.rec.tpc.nWaysOuter = 1;
configStandalone.rec.tpc.trackReferenceX = 83;
configStandalone.proc.outputSharedClusterMap = 1;
configStandalone.proc.clearO2OutputFromGPU = 1;
configStandalone.QA.clusterRejectionHistograms = 1;
configStandalone.proc.tpcIncreasedMinClustersPerRow = 500000;
configStandalone.proc.ignoreNonFatalGPUErrors = 1;
// TODO: rundEdx=1
// GPU_proc.qcRunFraction=$TPC_TRACKING_QC_RUN_FRACTION;"
// [[ $CTFINPUT == 1 ]] && GPU_CONFIG_KEY+="GPU_proc.tpcInputWithClusterRejection=1;"
// double pipeline / rtc
}

if (configStandalone.outputcontrolmem) {
Expand Down Expand Up @@ -893,7 +901,7 @@ int32_t main(int argc, char** argv)
double pipelineWalltime = 1.;
if (configStandalone.proc.doublePipeline) {
HighResTimer timerPipeline;
if (RunBenchmark(rec, chainTracking, 1, iEvent, &nTracksTotal, &nClustersTotal) || RunBenchmark(recPipeline, chainTrackingPipeline, 2, iEvent, &nTracksTotal, &nClustersTotal)) {
if (configStandalone.proc.debugLevel < 2 && (RunBenchmark(rec, chainTracking, 1, iEvent, &nTracksTotal, &nClustersTotal) || RunBenchmark(recPipeline, chainTrackingPipeline, 2, iEvent, &nTracksTotal, &nClustersTotal))) {
goto breakrun;
}
auto pipeline1 = std::async(std::launch::async, RunBenchmark, rec, chainTracking, configStandalone.runs, iEvent, &nTracksTotal, &nClustersTotal, 0, &timerPipeline);
Expand Down
7 changes: 6 additions & 1 deletion GPU/GPUTracking/Standalone/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,12 @@ if (GPUCA_BUILD_DEBUG_SANITIZE)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -shared-libasan")
endif()
endif()
string(APPEND CMAKE_CXX_FLAGS " -Wno-error -Wall -Wextra -Wshadow -Wno-unused-function -Wno-unused-parameter -Wno-unused-local-typedefs -Wno-unknown-pragmas -Wno-write-strings")
if(GPUCA_CONFIG_WERROR)
string(APPEND CMAKE_CXX_FLAGS " -Werror")
else()
string(APPEND CMAKE_CXX_FLAGS " -Wno-error")
endif()
string(APPEND CMAKE_CXX_FLAGS " -Wall -Wextra -Wshadow -Wno-unused-function -Wno-unused-parameter -Wno-unused-local-typedefs -Wno-unknown-pragmas -Wno-write-strings")
string(APPEND CMAKE_SHARED_LINKER_FLAGS " -rdynamic -Wl,--no-undefined")
if(CMAKE_CXX_COMPILER MATCHES "clang\\+\\+")
string(APPEND CMAKE_CXX_FLAGS " -Wno-vla-cxx-extension")
Expand Down
17 changes: 10 additions & 7 deletions GPU/GPUTracking/Standalone/cmake/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,16 @@ set -e
mkdir -p standalone/build
pushd standalone/build
cp $1/GPU/GPUTracking/Standalone/cmake/config.cmake .
cat >> config.cmake << "EOF"
set(ENABLE_CUDA 1)
set(ENABLE_HIP 1)
set(ENABLE_OPENCL 1)
set(GPUCA_CONFIG_ONNX 1)
set(GPUCA_BUILD_EVENT_DISPLAY 0)
EOF
if [[ $GPUCA_STANDALONE_CI == 1 ]]; then
cat >> config.cmake << "EOF"
set(ENABLE_CUDA 1)
set(ENABLE_HIP 1)
set(ENABLE_OPENCL 1)
set(GPUCA_CONFIG_ONNX 1)
set(GPUCA_BUILD_EVENT_DISPLAY 0)
set(GPUCA_CONFIG_WERROR 1)
EOF
fi
cmake -DCMAKE_INSTALL_PREFIX=../ $1/GPU/GPUTracking/Standalone
make ${JOBS+-j $JOBS} install
popd
1 change: 1 addition & 0 deletions GPU/GPUTracking/Standalone/cmake/config.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,5 @@ set(CUDA_COMPUTETARGET "default") # 86 89
#set(GPUCA_RTC_NO_COMPILED_KERNELS 1)
#set(GPUCA_KERNEL_RESOURCE_USAGE_VERBOSE 1)
#set(GPUCA_CONFIG_COMPILER gcc) # gcc / clang
#set(GPUCA_CONFIG_WERROR 1)
#add_definitions(-DGPUCA_GPU_DEBUG_PRINT)