fix!: use inject plugin instead of esbuild.banner#152
Open
sapphi-red wants to merge 1 commit intodavidmyersdev:mainfrom
Open
fix!: use inject plugin instead of esbuild.banner#152sapphi-red wants to merge 1 commit intodavidmyersdev:mainfrom
esbuild.banner#152sapphi-red wants to merge 1 commit intodavidmyersdev:mainfrom
Conversation
sapphi-red
changed the title
esbuild.banneresbuild.banner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #149.
This part of change does not make sense to me.
https://github.com/davidmyersdev/vite-plugin-node-polyfills/pull/149/changes#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R242-R246
jsxInjectis only used for JSX / TSX files but we need to inject these in JS / TS files as well.This PR changes the plugin to use
transformhook to inject variables in both dev and build. Since thetransformhook needsenforce: 'post'and the other hooks doesn't wantenforceto be specified, the plugin now returnsPlugin[]. This is technically a breaking change, but users won't need to change there config unless they are using Vite 2.x.close #142