feat: add connector and advertisement controllers #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachsmith1
force-pushed
the
feat/connector-controllers
branch
4 times, most recently
from
501f839 to
f1bb8dc
Compare
zachsmith1
force-pushed
the
feat/connector-controllers
branch
from
4931776 to
c8803af
Compare
scotwells
reviewed
Jan 22, 2026
scotwells
previously approved these changes
Jan 22, 2026
Contributor
scotwells
left a comment
scotwells
left a comment
There was a problem hiding this comment.
Couple more minor comments, but fine if those are resolved in a follow up PR.
scotwells
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectorandConnectorAdvertisementcontrollers that validate references, set Accepted conditions, and set owner refs for GC.Connectorlease lifecycle to indicate health based on the agent heartbeat resulting in aReadystatusConnectorAdvertisement.connectorRefrequired (non‑pointer) and adds default Accepted status conditions for bothConnectorandConnectorAdvertisement.Ref: datum-cloud/enhancements#556
Ref: datum-cloud/enhancements#483
Ref: datum-cloud/enhancements#508