Skip to content

670 ma api#546

Draft
JoseSzycho wants to merge 6 commits intomainfrom
670-ma-api
Draft

670 ma api#546
JoseSzycho wants to merge 6 commits intomainfrom
670-ma-api

Conversation

@JoseSzycho
Copy link
Copy Markdown
Contributor

@JoseSzycho JoseSzycho commented Mar 28, 2026

No description provided.

@JoseSzycho
feat: migraet machineAccountKey from IAM APIGroup to Identity APIGroup
34ab1b5 
This change is made to take advantage of the already custom storage layer of the identity APIGroup
@JoseSzycho
feat: implement MachineAccountKey RESTStorage and e2e tests
28f5da4 
This allows us to have a custom API for the machineAccountKeys, letting provision private keys and public key using Milo as the source of truth.

When Milo provision the private key, it won't be stored in the etcd, but will returned in teh update/create response.
@JoseSzycho
feat: implement protected resources and roles for machineAccount and …
1092e15 
…machineAccountKey
@JoseSzycho
fix: add missing Kustomize component to generate identity resource me…
c95dd44 
…trics ConfigMap
@JoseSzycho
refactor: Enforce MachineAccountKey spec immutability and remove cust…
95150cd 
…om update logic for key rotation.
@JoseSzycho JoseSzycho marked this pull request as draft March 28, 2026 19:51
@github-actions
chore: add missing newlines at end of files
9be63c0 
🤖 Automatically added newlines to 1 file(s)

Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@joggrbot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 28, 2026

🤖 I automatically added missing newlines at the end of 1 file(s) in this PR.

All files should now end with a newline character as per coding standards.

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Mar 28, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ JoseSzycho
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Mar 28, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ JoseSzycho
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JoseSzycho