Clean up organization memberships when users are deleted#544
Open
Clean up organization memberships when users are deleted#544
Conversation
Contributor
Add a finalizer to the UserController that deletes all OrganizationMemberships referencing a user before allowing the User object to be removed. This prevents PolicyBindings owned by those memberships from becoming permanently orphaned. Also fixes: - OrganizationMembership validation webhook now allows last-owner membership deletion when the referenced User is being deleted - Organization webhook sets User ownerReference on memberships - UserInvitation controller fixes malformed ownerReference APIVersion - OrganizationMembership controller self-deletes after two-pass confirmation when the referenced User no longer exists Closes #536 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1f29aaa to
485ee94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
When a User was deleted, OrganizationMembership resources referencing that user were not cleaned up because they had no User ownerReference (webhook creation path) or had a malformed one (invitation path used
.Groupinstead of.String()for APIVersion). The orphaned memberships left their owned PolicyBindings stuck inSubjectValidationFailedstate.Closes #536
Test plan
🤖 Generated with Claude Code