Skip to content

fix: clear metadata finalizers in namespace purge #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoseSzycho wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clear metadata finalizers in namespace purge #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/controllers/projectpurge/purge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ func (p *Purger) Purge(ctx context.Context, cfg *rest.Config, project string, o
_ = core.CoreV1().Namespaces().Delete(ctx, ns, delOpts)
}

// Clear finalizers to allow immediate removal without a namespace controller
nso.Spec.Finalizers = nil
// Clear metadata finalizers to allow immediate removal without a namespace controller
nso.ObjectMeta.Finalizers = nil
if _, err := core.CoreV1().Namespaces().Finalize(ctx, nso, metav1.UpdateOptions{}); !ignorable(err) {
if apierrors.IsForbidden(err) || apierrors.IsUnauthorized(err) {
return fmt.Errorf("rbac forbids namespaces/finalize on %q: %w", ns, err)
Expand Down
Loading