feat: add user agent field and updatedAt to session endpoint#534
Open
mattdjenkinson wants to merge 6 commits intomainfrom
Open
feat: add user agent field and updatedAt to session endpoint#534mattdjenkinson wants to merge 6 commits intomainfrom
mattdjenkinson wants to merge 6 commits intomainfrom
Conversation
Contributor
mattdjenkinson
requested review from
JoseSzycho,
kevwilliams,
scotwells and
zachsmith1
scotwells
reviewed
Mar 23, 2026
kevwilliams
previously approved these changes
Mar 23, 2026
mattdjenkinson
changed the title
Author
|
@scotwells could you take a look at this again please? I've added an |
scotwells
previously approved these changes
Mar 25, 2026
Contributor
scotwells
left a comment
scotwells
left a comment
There was a problem hiding this comment.
Looks good. Let's test with Zitadel before we merge this in. Assume you confirmed all these fields are available from Zitadel?
Author
|
@scotwells yeah, will push my branch for Zitadel and put on staging. |
mattdjenkinson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fields for location, client details and last active to the user session. Once this is merged i'll raise a PR for auth-provider-zitadel to populate these fields.