Skip to content

feat: only update status when allowance bucket changes #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotwells merged 1 commit into from
Jan 20, 2026
Merged

feat: only update status when allowance bucket changes #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 23 additions & 14 deletions internal/quota/controllers/core/bucket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import (
"crypto/sha256"
"fmt"

"k8s.io/apimachinery/pkg/api/equality"
apierrors "k8s.io/apimachinery/pkg/api/errors"
apimeta "k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down Expand Up @@ -86,36 +87,26 @@ func (r *AllowanceBucketController) Reconcile(ctx context.Context, req mcreconci
}
}

// Update observed generation
originalStatus := bucket.Status.DeepCopy()

bucket.Status.ObservedGeneration = bucket.Generation

// Calculate limits from ResourceGrants
if err := r.updateLimitsFromGrants(ctx, clusterClient, &bucket); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to update limits from grants: %w", err)
}

// Calculate usage from ResourceClaims
if err := r.updateUsageFromClaims(ctx, clusterClient, &bucket); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to update usage from claims: %w", err)
}

// Try to grant pending claims by reserving capacity
// processPendingClaims performs intermediate status updates for atomic quota reservation.
if err := r.processPendingClaims(ctx, clusterClient, &bucket); err != nil {
return ctrl.Result{}, fmt.Errorf("failed processing pending grants: %w", err)
}

// Enforce non-negative Available quota (validation constraint)
bucket.Status.Available = max(0, bucket.Status.Limit-bucket.Status.Allocated)

// Update last reconciliation time
bucket.Status.LastReconciliation = ptr.To(metav1.Now())

// API server handles no-op updates efficiently
if err := clusterClient.Status().Update(ctx, &bucket); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to update AllowanceBucket status: %w", err)
}

return ctrl.Result{}, nil
return r.updateStatusIfChanged(ctx, clusterClient, &bucket, originalStatus)
}

// updateLimitsFromGrants calculates total quota limits from active ResourceGrants.
Expand Down Expand Up @@ -406,6 +397,24 @@ func (r *AllowanceBucketController) updateResourceClaimAllocation(ctx context.Co
return nil
}

// updateStatusIfChanged updates the bucket status if it changed.
// Skips the update if the status is semantically identical to prevent unnecessary
// API server writes and audit log entries. Updates the LastReconciliation timestamp
// only when status changes.
func (r *AllowanceBucketController) updateStatusIfChanged(ctx context.Context, clusterClient client.Client, bucket *quotav1alpha1.AllowanceBucket, originalStatus *quotav1alpha1.AllowanceBucketStatus) (ctrl.Result, error) {
if equality.Semantic.DeepEqual(&bucket.Status, originalStatus) {
return ctrl.Result{}, nil
}

bucket.Status.LastReconciliation = ptr.To(metav1.Now())

if err := clusterClient.Status().Update(ctx, bucket); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to update AllowanceBucket status: %w", err)
}

return ctrl.Result{}, nil
}

// generateAllowanceBucketName creates a deterministic name for an AllowanceBucket.
// Buckets are global per consumer and resource type, not per claim namespace.
func generateAllowanceBucketName(resourceType string, ownerRef quotav1alpha1.ConsumerRef) string {
Expand Down
Loading