-
Notifications
You must be signed in to change notification settings - Fork 2
feat(github): update nix hash on relevant PR instead of main branch #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@drewr have you confirmed this works? Think you should be able to modify the |
|
I didn't think I could until the workflow was in |
|
Looks like I can. 🤞 |
|
Well it doesn't not work... |
|
Not sure why it showed up both as its own check and under |
This will match the way the tests are run
|
OK, I think this works better. However, since there hasn't been a real deps change the hash hasn't needed updating, so there isn't a commit, but I can't see why that wouldn't have worked (famous last words). |
|
@drewr yeah a workflow by definition is a check. We'll just need to configure the branch protection policy to require that check complete before allowing the PR to be merged. |

Hopefully this addresses the root cause of #83 which is that staying on top of the generated PRs was challenging.