chore(device): guide the user during device auth#67
Open
gianarb wants to merge 3 commits intodatum-cloud:mainfrom
Open
chore(device): guide the user during device auth#67gianarb wants to merge 3 commits intodatum-cloud:mainfrom
gianarb wants to merge 3 commits intodatum-cloud:mainfrom
Conversation
scotwells
previously approved these changes
Mar 30, 2026
gianarb
force-pushed
the
fix/guide-user-to-device-auth
branch
from
23d87b3 to
236ae5b
Compare
scotwells
previously approved these changes
Mar 31, 2026
scotwells
left a comment
scotwells
left a comment
There was a problem hiding this comment.
@mattdjenkinson @yahyafakhroji is the build failure here expected?
Collaborator
|
@scotwells no, this one should pass. |
The flow is now: 1. Consent page: button says "Allow & Sign In" + notice "You'll need to sign in to complete the authorization." 2. Login page: info banner "Sign in to authorize the device and complete the connection."
gianarb
force-pushed
the
fix/guide-user-to-device-auth
branch
from
fe669e5 to
4313b80
Compare
yahyafakhroji
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flow is now: