Skip to content

Conversation

@akash-shankaran
Copy link

Add AVX512 support for Dot Product

Signed-off-by: akash shankaran <akash.shankaran1@gmail.com>
@ashkrisk
Copy link
Contributor

AVX512 should automatically be picked up by dotProductPreferred, since the preferred vector species will already be SPECIES_512 on supported platforms. If I'm not mistaken, this PR is primarily useful for future-proofing in cases where a bigger vector species might exist (say 1024-bits), but the vector length is in-between 512 and 1024 bits. As a suggestion, how about changing the PR title to reflect that?

@marianotepper
Copy link
Collaborator

@ashkrisk is right. Until wider SIMD instructions become available, we should be good with the "preferred" implementation.

@akash-shankaran
Copy link
Author

Makes sense. Thanks for your comments @ashkrisk and @marianotepper. I didn't realize the dotProductPreferred covered the AVX512 case, which is what I was trying to add.

I don't think its worth adding code to future-proof the implementation, and we can wait for wider SIMD registers to be available in hardware. I'll close the PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants