Invoke-TlsWebRequest - Auto-detect system proxy#10310
Open
andreasjordan wants to merge 2 commits intodevelopmentfrom
Open
Invoke-TlsWebRequest - Auto-detect system proxy#10310andreasjordan wants to merge 2 commits intodevelopmentfrom
andreasjordan wants to merge 2 commits intodevelopmentfrom
Conversation
…xy() Adds automatic proxy detection to Invoke-TlsWebRequest by calling [System.Net.WebRequest]::GetSystemWebProxy() when no proxy is already configured. This provides PAC file support and cross-platform compatibility (PS7 on Linux/macOS uses HTTP_PROXY/HTTPS_PROXY env vars; PS5.1 on Windows uses WinINET). All callers benefit without individual changes. Fixes #5884 (do *Web*) Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
Member
|
looking forward to this one 👍🏼 |
Collaborator
Author
|
@claude please create a config item to opt out like Chrissy sugessted in the issue. |
|
Claude finished @andreasjordan's task in 1m 58s —— View job Added opt-out config item
Changes made:
Set-DbatoolsConfig -FullName 'commands.invoke-tlswebrequest.disableautoproxy' -Value $false -Initialize -Validation bool -Description "Disable automatic system proxy detection in Invoke-TlsWebRequest. Set to true to skip auto-detection of the system proxy (useful if auto-detection causes issues in your environment)."
# Auto-detect system proxy if not already configured and not opted out
if (-not (Get-DbatoolsConfigValue -FullName "commands.invoke-tlswebrequest.disableautoproxy") -and -not [System.Net.WebRequest]::DefaultWebProxy.Address) {Users who want to opt out can run: Set-DbatoolsConfig -FullName 'commands.invoke-tlswebrequest.disableautoproxy' -Value $true| |
(do Invoke-TlsWebRequest) Co-authored-by: Andreas Jordan <andreasjordan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds automatic proxy detection to
Invoke-TlsWebRequestusing[System.Net.WebRequest]::GetSystemWebProxy(). When no proxy is already configured, the system proxy is detected and set with default network credentials. Supports PAC files and is cross-platform. All callers benefit without individual changes.Fixes #5884
Generated with Claude Code