ACS5: restrict state_county_blockgroup to 2013+#169
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
Block group geography wasn't published in the ACS API until 2013. Calling state_county_blockgroup with an earlier year currently hits the Census API and comes back with 'unknown/unsupported geography hierarchy', which doesn't help anyone diagnose the actual problem. Narrow the @supported_years on this method so callers get an UnsupportedYearException up front instead, matching the behavior of the other geography-specific methods on the class. Closes datamade#140, datamade#155. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block group geography wasn't published in the ACS API until 2013 (2012 geography schema vs 2013 geography schema). Calling
state_county_blockgroupwith an earlier year currently makes the API trip and returnunknown/unsupported geography hierarchy, which is hard to diagnose. Narrow the@supported_yearsso callers get the localUnsupportedYearExceptionup front instead, like the other geography-specific methods already do.Behavior change is just on years 2009-2012, which the API was rejecting anyway.
Closes #140.
Closes #155.