Switch ACS/SF1/PL endpoints on fields() too#168
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
tables() and get() on the ACS, SF1, and PL clients call _switch_endpoints first to point at the correct dataset URL. fields() didn't, so it inherits Client.fields() unchanged and hits whatever endpoint was set last (or the generic Census one), which 404s and produces a JSON decode error. Calling tables() first happens to mask this because tables flips the endpoint as a side effect. Hitting fields() before anything else is the broken path. Closes datamade#138. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tables()andget()on the ACS, SF1, and PL clients each wrap themselves with a_switch_endpointscall so the dataset-specific URLs are set before the request goes out.fields()doesn't, so it just inheritsClient.fields()and hits whatever URL was set last (or the generic Census one), which 404s and the response fails to decode as JSON.The reason it usually looks fine is that calling
tables()first happens to set the endpoint as a side effect. Hittingfields()before anything else is the broken path (@ptwales' repro in the issue).Added the wrapper to all three clients that already had this pattern. Also added a
test_fieldstest mirroringtest_tables.Closes #138.